Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wpilib version and replace VideoMode equality #873

Closed
wants to merge 8 commits into from

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Jun 18, 2023

No description provided.

@mcm001 mcm001 requested a review from a team as a code owner June 18, 2023 22:58
@srimanachanta
Copy link
Member

If it is just MacOS builds, why not hold off until the beta releases are done so more concrete stuff can be implemented? We should wait till at least wpilibsuite/allwpilib#5397 is merged.

@srimanachanta srimanachanta changed the title Bump wpilib versionto fix mac test builds Bump wpilib version and replace VideoMode equality Jun 21, 2023
@srimanachanta
Copy link
Member

I just combined the changes from #859 due to our discussion in discord regarding bumping this PR regardless

@mcm001
Copy link
Contributor Author

mcm001 commented Jun 24, 2023

Looks like this breaks on raspberry pi devices:

image
https://discord.com/channels/725836368059826228/753739620050665523/1122179346929561700

@mcm001 mcm001 marked this pull request as draft June 24, 2023 21:48
@srimanachanta
Copy link
Member

Just in case I don't remember when this gets reviewed next, adding an equality check makes libcamera non functional for some reason.

@mdurrani808 mdurrani808 added this to the 2024 Beta milestone Sep 26, 2023
@mcm001
Copy link
Contributor Author

mcm001 commented Oct 15, 2023

Unclear if this PR is still relevant?

@srimanachanta
Copy link
Member

Unclear if this PR is still relevant?

This PR actually breaks libcamera completely for some reason, might be better just to kill it cause the wpilib bump is already implemented

@mcm001
Copy link
Contributor Author

mcm001 commented Oct 15, 2023

Closing, can reopen later. Mac issue still is present, need a new issue cut to disable mac builds

@mcm001 mcm001 closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants