Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable maximiumPoseAmbiguityThreshold for use in PhotonPoseEstimator #773

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JohnGilb
Copy link

When cameras are distant from AprilTags, it's quite common to have very high pose ambiguities, leading to significant deviations in estimated pose. Since the PhotonPoseEstimator calls camera.getLatestResult() internally, there's no opportunity for user code to check the values in that result and do any filtering of their own.

This PR adds a configurable threshold, via setMaximumPoseAmbiguityThreshold(double maximumPoseAmbiguityThreshold), that is used in the update() method of PhotonPoseEstimator to remove any targets with high pose ambiguities from consideration by the various strategies.

@JohnGilb JohnGilb requested a review from a team as a code owner January 28, 2023 01:23
@JohnGilb JohnGilb marked this pull request as draft January 28, 2023 02:04
@mdurrani808
Copy link
Contributor

Any updates?

@JohnGilb
Copy link
Author

I have somebody on my team with C++ background, but not sure if they'll have the time to implement that before Week 1 competitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants