Add configurable maximiumPoseAmbiguityThreshold for use in PhotonPoseEstimator #773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cameras are distant from AprilTags, it's quite common to have very high pose ambiguities, leading to significant deviations in estimated pose. Since the PhotonPoseEstimator calls
camera.getLatestResult()
internally, there's no opportunity for user code to check the values in that result and do any filtering of their own.This PR adds a configurable threshold, via
setMaximumPoseAmbiguityThreshold(double maximumPoseAmbiguityThreshold)
, that is used in theupdate()
method of PhotonPoseEstimator to remove any targets with high pose ambiguities from consideration by the various strategies.