Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP based settings when new fullsettings are emited #1122

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

srimanachanta
Copy link
Member

Previously, if someone were changing network or camera settings while the backend sent an update request, the frontend wouldn't update the UI until the HTTP request was sent, likely leading to an error or confusion, now, values will be reset whenever new settings are sent. It also checks that settings were changed before allowing the user to click the save button.

  • updates styling of the camera settings save button to be full-width (this was done to match the NetworkSettings section)
  • Residual cleanup from Check all new prop names not just exposure time #1080
    • Correctly Types Quirks to the UI
    • Updates how quirks are manipulated by the selector
    • Hides the selector on non-arducam cameras
    • Fixes a bug where store values wouldn't be updated by remote changes or after save success/error

@srimanachanta srimanachanta requested a review from a team as a code owner January 6, 2024 06:15
photon-client/src/types/SettingTypes.ts Outdated Show resolved Hide resolved
@mcm001 mcm001 merged commit bf156f5 into PhotonVision:master Jan 6, 2024
23 checks passed
@srimanachanta srimanachanta deleted the idk-what-to-name-this branch January 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants