Fix grayscale passthrough #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ov9281 exposure 0 through 6 do not actually do anything. Gain of 0 would also enable auto exposure.
mcm001
reviewed
Jan 1, 2024
photon-core/src/main/java/org/photonvision/vision/camera/LibcameraGpuSettables.java
Outdated
Show resolved
Hide resolved
|
Please update the description with a link to the libcamera-driver PR, and also include verification (screenshot, comment) this does what it says it will |
mcm001
reviewed
Jan 2, 2024
photon-core/src/main/java/org/photonvision/vision/camera/LibcameraGpuSettables.java
Outdated
Show resolved
Hide resolved
mcm001
approved these changes
Jan 2, 2024
|
Need to merge #11 and then bump the libcamera version right? |
|
Needs a libcamera bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix grayscale passthrough with libcamera. Additionally fixes issue #1091.
Must go with PhotonVision/photon-libcamera-gl-driver#11.
When grayscale passthrough is used currently the frames that are returned do not have the type grayscale so calculations that need grayscale to not run. With these changes pipelines that need grayscale will now run and properly display fps.
BEFORE:
AFTER:
