Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all new prop names not just exposure time #1080

Merged
merged 19 commits into from
Jan 6, 2024

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Dec 28, 2023

No description provided.

@mcm001 mcm001 marked this pull request as ready for review December 28, 2023 16:37
@mcm001 mcm001 requested a review from a team as a code owner December 28, 2023 16:37
@mcm001 mcm001 added this to the 2024 Kickkoff milestone Dec 29, 2023
@randomstring
Copy link

Turning on auto-exposure from off works. However turning off auto-exposure from on does not turn off auto-exposure until you then change the manual exposure setting. I confirmed this by a) looking at the video stream and b) by running v4l2-ctl -d /dev/video0 --list-ctrls-menus | grep exposure

@randomstring
Copy link

The control over 'exposure_time_absolute' is more granular than the UI suggests. This seems like some sort of interpolation of rounding error.

Values from [0,0.5] map to an 'exposure_time_absolute' of 1
values [0.6,1.4] map to an 'exposure_time_absolute' of 50
values [1.5,?] map to 100
an so on.

I have found exposure times on the ov9281 useful down to 25.

@randomstring
Copy link

Ah, I think I see the problem with the changing exposure from ON -> OFF. code is missing the step of resetting the property.

I'm building/testing a fix.

@randomstring
Copy link

This fix is working for me. auto exposure on->off and off->on. turning off auto exposure returns to the last manual exposure setting.

@mcm001 mcm001 force-pushed the 2023-12-27_exposuretimeabsolute' branch from ca4ed67 to 02bbe9b Compare January 6, 2024 01:33
Copy link
Contributor

@BytingBulldogs3539 BytingBulldogs3539 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...

@mcm001 mcm001 merged commit 4068025 into PhotonVision:master Jan 6, 2024
23 checks passed
@mcm001 mcm001 deleted the 2023-12-27_exposuretimeabsolute' branch January 6, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants