Add option to also publish Protobuf version of results from backend #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was done before but incorrectly
mcm001
reviewed
Dec 30, 2023
mcm001
reviewed
Dec 30, 2023
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Dec 30, 2023
photon-targeting/src/main/java/org/photonvision/targeting/proto/MultiTargetPNPResultProto.java
Outdated
Show resolved
Hide resolved
mcm001
approved these changes
Dec 30, 2023
|
Tested with beta 4 glass, works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows logging software and live data view to see results. Also removes the requirement for AScope to keep up with the packet serde schema and instead just use the Protobuf descriptor.