Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[photonlib] Improve PhotonUtils #925

Open
amquake opened this issue Sep 27, 2023 · 1 comment
Open

[photonlib] Improve PhotonUtils #925

amquake opened this issue Sep 27, 2023 · 1 comment

Comments

@amquake
Copy link
Member

amquake commented Sep 27, 2023

The current PhotonUtils class makes some assumptions about the camera's rotation relative to the robot, and does not support 3d geometry. Related issue: wpilibsuite/allwpilib#4757

I previously attempted to update this class (link) while testing with trigonometry calculations in simulation to handle 3d geometry, but I'm not sure what the best user API would look like.

Note: these calculations would be affected by #896 !
@mcm001
Copy link
Contributor

mcm001 commented Nov 2, 2024

@amquake this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amquake @mcm001