Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python support in 2024 #836

Closed
virtuald opened this issue Apr 3, 2023 · 3 comments
Closed

python support in 2024 #836

virtuald opened this issue Apr 3, 2023 · 3 comments
Milestone

Comments

@virtuald
Copy link

virtuald commented Apr 3, 2023

It is expected that Python will be an official FRC language in 2024. Currently the RobotPy project maintains a variety of python wrappers around useful vendor libraries, and we expect to maintain those at least initially until vendors decide they want to provide support themselves. Most vendor libraries have no dependencies other than WPILib, and use fairly vanilla C++, so they're fairly easy to provide support for.

Unfortunately, PhotonVision's vendor library has been broken for RobotPy teams this year because.. well, I'm not 100% sure since I haven't personally done the wrapping, but I think it's because the vendor library now uses OpenCV and doesn't embed it (like the apriltags library does) and because some of your C++ objects use move-only semantics (which is incompatible with pybind11).

Given these issues, I don't really want to spend time on PhotonVision python wrappers in 2024, and I'd rather the PhotonVision project support it instead. It seems to me that if you're building the python wheels as part of your CI process, then you'll be more likely to notice any breakages. Building the python wrappers in-tree instead of depending on a built vendor library should be pretty straightforward, and we're happy to provide some initial assistance to copy the wrapper code over and integrate with your CI. We could also transfer over the existing robotpy-photonvision pypi package to the PhotonVision project, or you could use a new python package name.

CC @auscompgeek


For reference, here are some of the patches and PRs for RobotPy.

Patches for 2023.3.0:

PR for 2023.4.x that hasn't been resolved: https://github.com/robotpy/robotpy-photonvision/pull/19/files

@mcm001 mcm001 added this to the 2024 Kickkoff milestone May 30, 2023
@virtuald
Copy link
Author

virtuald commented Dec 8, 2023

I've asked the community to step up and support it here: https://www.chiefdelphi.com/t/dropping-robotpy-photonvision-support/445590

@mcm001
Copy link
Contributor

mcm001 commented Dec 8, 2023

I would be happy to see this mainlined if someone can step up and take ownership of this refactor

@mcm001
Copy link
Contributor

mcm001 commented Jan 4, 2024

Closed by #1040

@mcm001 mcm001 closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants