better unit test passing

PhotonVision · Dec 12, 2023 · d63bb2f · d63bb2f
1 parent 9364d21
commit d63bb2f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/photon-lib/py/photonlibpy/multiTargetPNPResult.py b/photon-lib/py/photonlibpy/multiTargetPNPResult.py
@@ -1,4 +1,4 @@
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 from wpimath.geometry import Transform3d
 from photonlibpy.packet import Packet
 
@@ -9,8 +9,8 @@ class PNPResult:
     PACK_SIZE_BYTES = 1 + (_NUM_BYTES_IN_FLOAT * 7 * 2) + (_NUM_BYTES_IN_FLOAT* 3)
 
     isPresent:bool = False
-    best:Transform3d = Transform3d()
-    alt:Transform3d = Transform3d()
+    best:Transform3d = field(default_factory=Transform3d)
+    alt:Transform3d = field(default_factory=Transform3d)
     ambiguity:float = 0.0
     bestReprojError:float = 0.0
     altReprojError:float = 0.0
@@ -31,8 +31,8 @@ class MultiTargetPNPResult:
     # pnpresult + MAX_IDS possible targets (arbitrary upper limit that should never be hit, ideally)
     _PACK_SIZE_BYTES = PNPResult.PACK_SIZE_BYTES + (1 * _MAX_IDS)
 
-    estimatedPose:PNPResult = PNPResult()
-    fiducialIDsUsed:list[int] = []
+    estimatedPose:PNPResult = field(default_factory=PNPResult)
+    fiducialIDsUsed:list[int] = field(default_factory=list)
 
     def createFromPacket(self, packet:Packet) -> Packet:
         self.estimatedPose = PNPResult()

diff --git a/photon-lib/py/photonlibpy/photonPipelineResult.py b/photon-lib/py/photonlibpy/photonPipelineResult.py
@@ -1,4 +1,4 @@
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 
 from photonlibpy.multiTargetPNPResult import MultiTargetPNPResult
 from photonlibpy.packet import Packet
@@ -8,8 +8,8 @@
 class PhotonPipelineResult:
     latencyMillis:float = -1.0
     timestampSec:float = -1.0
-    targets:list[PhotonTrackedTarget] = []
-    multiTagResult:MultiTargetPNPResult = MultiTargetPNPResult()
+    targets:list[PhotonTrackedTarget] = field(default_factory=list)
+    multiTagResult:MultiTargetPNPResult = field(default_factory=MultiTargetPNPResult)
 
     def populateFromPacket(self, packet:Packet) -> Packet:
         self.targets = []

diff --git a/photon-lib/py/photonlibpy/photonTrackedTarget.py b/photon-lib/py/photonlibpy/photonTrackedTarget.py
@@ -1,4 +1,4 @@
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 from wpimath.geometry import Transform3d
 from photonlibpy.packet import Packet
 
@@ -21,8 +21,8 @@ class PhotonTrackedTarget:
     area:float = 0.0
     skew:float = 0.0
     fiducialId:int  = -1
-    bestCameraToTarget:Transform3d  = Transform3d()
-    altCameraToTarget:Transform3d  = Transform3d()
+    bestCameraToTarget:Transform3d = field(default_factory=Transform3d)
+    altCameraToTarget:Transform3d  = field(default_factory=Transform3d)
     minAreaRectCorners:list[TargetCorner]|None = None
     detectedCorners:list[TargetCorner]|None = None
     poseAmbiguity:float = 0.0