Build photonlib json first (#952)

PhotonVision · Oct 15, 2023 · 7f94962 · 7f94962
1 parent c8c9e77
commit 7f94962
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/photon-lib/build.gradle b/photon-lib/build.gradle
@@ -120,23 +120,22 @@ task generateVendorJson() {
     outputs.file photonlibFileOutput
     inputs.file photonlibFileInput
 
-    doLast {
-        println "Writing version ${pubVersion} to $photonlibFileOutput"
+        println "Writing vendor JSON ${pubVersion} to $photonlibFileOutput"
 
         if (photonlibFileOutput.exists()) {
             photonlibFileOutput.delete()
         }
+        photonlibFileOutput.parentFile.mkdirs()
+
         def read = photonlibFileInput.text
             .replace('${photon_version}', pubVersion)
             .replace('${frc_year}', frcYear)
-        photonlibFileOutput.write(read)
-    }
+        photonlibFileOutput.text = read
 
     outputs.upToDateWhen { false }
 }
 
-build.dependsOn generateVendorJson
-
+build.mustRunAfter generateVendorJson
 
 task writeCurrentVersion {
     def versionFileIn = file("${rootDir}/shared/PhotonVersion.java.in")
@@ -147,7 +146,7 @@ task writeCurrentVersion {
             versionString)
 }
 
-build.dependsOn writeCurrentVersion
+build.mustRunAfter writeCurrentVersion
 
 tasks.withType(Javadoc) {
     options.encoding = 'UTF-8'

diff --git a/photon-lib/publish.gradle b/photon-lib/publish.gradle
@@ -198,8 +198,7 @@ model {
     }
 }
 
-// So I don't actually know the _right_ way to tell gradle that the vendordep json publish requires generation first, so we're doing this
-getTasksByName("publishVendorjsonPublicationToMavenLocal", false).each {
+tasks.withType(PublishToMavenRepository) {
     it.mustRunAfter generateVendorJson
 }