Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remote Docker #21

Open
madoar opened this issue Oct 16, 2018 · 5 comments
Open

Support remote Docker #21

madoar opened this issue Oct 16, 2018 · 5 comments
Labels

Comments

@madoar
Copy link

madoar commented Oct 16, 2018

As far as I understand the code, winebuild currently requires docker to be installed alongside it to function correctly.

This may not be the case on every system.
Therefore, I think we should use a config file to specify the location of the docker service used by winebuild.

@qparis
Copy link
Member

qparis commented Oct 16, 2018

Why not directly install winebuild alongside with the system that has docker?

@madoar
Copy link
Author

madoar commented Oct 17, 2018

I'm not saying that you mustn't do that, I just describe the possibility that someone dosn't want to install winebuild on the same system on which docker is installed.
A possible reason could be, that you have a dedicated server only for executing docker containers.

When reading my own issue I understand that I forgot to add some additional context:
In addition to making the location of the docker service configurable, I also want to recommend using a python library to communicate with docker instead of a process builder.
This would remove the direct dependency on docker, when installing/executing winebuild.

@plata
Copy link
Contributor

plata commented Oct 17, 2018

I like the idea to use a python library. docker-py could be an option.

@qparis
Copy link
Member

qparis commented Oct 17, 2018

Sounds good to me too

@qparis
Copy link
Member

qparis commented Oct 17, 2018

System calls have been replaced with docker-py. Should not be too hard to support remote Docker now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants