You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IMHO, the correct way for testcover to work would be to add -MDevel::Cover to the harness_switches, as they are passed on correctly to both Test::Harness and TAP::Harness.
Seen on Gentoo Linux amd64, Perl 5.20.2 and Module::Build from git master, as well as 0.4214.
The text was updated successfully, but these errors were encountered:
The action
testcover
needs to set-MDevel::Cover
when tests are executed, so that coverage metrics are collected. Currently, it tries to achieve this by these lines of code:(https://github.com/Perl-Toolchain-Gang/Module-Build/blob/master/lib/Module/Build/Base.pm#L2805)
This is broken in two ways:
Test::Harness::switches
will be overwritten inrun_test_harness
, so setting it here has no effect whatsoever.HARNESS_PERL_SWITCHES
is only valued byTest::Harness
, but notTAP::Harness
.The result is that
testcover
only works with Test::Harness:but not in TAP::Harness:
IMHO, the correct way for
testcover
to work would be to add-MDevel::Cover
to theharness_switches
, as they are passed on correctly to both Test::Harness and TAP::Harness.Seen on Gentoo Linux amd64, Perl 5.20.2 and Module::Build from git master, as well as 0.4214.
The text was updated successfully, but these errors were encountered: