Make "No such file or directory" errors more descriptive #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, "No such file or directory" errors would point to this line in this file, i.e. `fileError(2, "No such file or directory /Users/[redacted]/Desktop/Programming/Swift/Perfect/[redacted]/Core/.build/checkouts/PerfectLib.git-3712999737848873669/Sources/PerfectLib/File.swift open(_:permissions:) 245")` This change will replace that error with: `fileError(2, "No such file or directory /Users/[redacted]/Desktop/Programming/Swift/Perfect/[redacted]/log/log.log open(_:permissions:) 244")`
|
I want to make sure that http server doesn't barf out potentially sensitive information by default. I know that error message needs to be fixed (as you did) but I want to make sure the implications are dealt with first. |
|
That makes perfect (heh) sense. I didn't think of that since I'm planning on having custom error pages anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, "No such file or directory" errors would point to this line in this file, i.e.
fileError(2, "No such file or directory /Users/[redacted]/Desktop/Programming/Swift/Perfect/[redacted]/Core/.build/checkouts/PerfectLib.git-3712999737848873669/Sources/PerfectLib/File.swift open(_:permissions:) 245")This change will replace that error with:
fileError(2, "No such file or directory /Users/[redacted]/Desktop/Programming/Swift/Perfect/[redacted]/log/log.log open(_:permissions:) 244")