Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning.tensor mps docs #756

Merged
merged 504 commits into from
Jun 14, 2024
Merged

lightning.tensor mps docs #756

merged 504 commits into from
Jun 14, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Jun 7, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Add lightning.tensor documentation.
The requirement of this doc is Basic documentation and developer-facing notes
[SC-62441]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

multiphaseCFD and others added 30 commits June 4, 2024 12:42
**Context:**
As name says. `QNode` now accepts `postselect_shots` and `mcm_method`
arguments to specify MCM behaviour. This PR updates LQ to adhere to
those arguments.

**Description of the Change:**
* Update LQ preprocessing to adhere to user requested MCM behaviour
* Add tests for LQ and LK
* Update LQ and LK simulation to adhere to specified `postselect_mode`.

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: ringo-but-quantum <[email protected]>
@multiphaseCFD multiphaseCFD requested review from vincentmr and maliasadi and removed request for maliasadi June 14, 2024 12:49
@AmintorDusko AmintorDusko self-requested a review June 14, 2024 14:42
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. I will test following the instructions and report back later today.

README.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
pennylane_lightning/lightning_tensor/lightning_tensor.py Outdated Show resolved Hide resolved
pennylane_lightning/lightning_tensor/lightning_tensor.py Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD . I can build LT with your instructions. Happy to approve.

doc/lightning_tensor/package.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
multiphaseCFD and others added 2 commits June 14, 2024 13:56
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested and I could install it by following the steps here.
Thank you, @multiphaseCFD!

@multiphaseCFD multiphaseCFD merged commit 52710ff into master Jun 14, 2024
86 checks passed
@multiphaseCFD multiphaseCFD deleted the ltensor_mps_docs branch June 14, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants