Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apply state vector when using a lightning handle #622

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

AmintorDusko
Copy link
Contributor

Context: This PR fixes a recent code error found when asking to apply a state vector with a handle to the Lightning C++ class.

Description of the Change: The fix was made, and unit tests were added.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (57d87c6) to head (7c33a20).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         169      169           
  Lines       24020    24020           
=======================================
  Hits        23708    23708           
  Misses        312      312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko marked this pull request as ready for review February 28, 2024 19:13
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AmintorDusko AmintorDusko requested a review from a team February 28, 2024 19:17
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch @AmintorDusko !

@AmintorDusko AmintorDusko merged commit 03e465d into master Feb 28, 2024
86 checks passed
@AmintorDusko AmintorDusko deleted the fix__apply_state_vector branch February 28, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants