Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Change ValueRange to ResultRange in gate_op's result getters #1192

Open
paul0403 opened this issue Oct 8, 2024 · 0 comments
Open

[QoL] Change ValueRange to ResultRange in gate_op's result getters #1192

paul0403 opened this issue Oct 8, 2024 · 0 comments
Labels
compiler Pull requests that update the compiler enhancement New feature or request

Comments

@paul0403
Copy link
Contributor

paul0403 commented Oct 8, 2024

We have some convenience result/operand getters for gate operations, and currently they all return ValueRange.

Nothing is inherently wrong with this, but ResultRange has the replace methods built-in, and ValueRange does not.

To avoid manually casting or looping, we can change the result getters to return ResultRange directly, or provide an overloaded result getter.

@paul0403 paul0403 added enhancement New feature or request compiler Pull requests that update the compiler labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Pull requests that update the compiler enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant