From b576a3ef64d77ab9ad98857b277ac50a3e900cdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janne=20Kiiskil=C3=A4?= Date: Fri, 31 May 2024 11:27:47 +0300 Subject: [PATCH] Make CI more robust Failure now in master merge, because runner did not have shellcheck. Install it. --- .github/workflows/pr-checker.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-checker.yml b/.github/workflows/pr-checker.yml index 584253e..9a1b8e0 100644 --- a/.github/workflows/pr-checker.yml +++ b/.github/workflows/pr-checker.yml @@ -13,6 +13,7 @@ jobs: runs-on: [ "self-hosted", "client" ] steps: - uses: actions/checkout@v4 + - run: sudo apt-get update && sudo apt-get install -y shellcheck - run: shellcheck --version - name: Shellcheck fw-tools/edge-testnet run: shellcheck fw-tools/edge-testnet @@ -44,7 +45,7 @@ jobs: steps: - uses: actions/checkout@v4 # Install pyshcheck tooling - - run: sudo apt install -y pycodestyle pydocstyle black + - run: sudo apt-get update && sudo apt-get install -y pycodestyle pydocstyle black # git instead of rules to use access token - run: git config --global url."https://${{ secrets.ACCESS_TOKEN }}@github.com/".insteadOf "git@github.com:" - run: git config --global url."https://${{ secrets.ACCESS_TOKEN }}@github".insteadOf "https://github" @@ -75,7 +76,7 @@ jobs: echo "Failed to run edge-testnet -d example.com" exit 1 fi - - name: Check if it works with a custom domain & snap + - name: Check if it works with a custom domain & SNAP env defined run: | if ! SNAP=snap fw-tools/edge-testnet --domain -pr-tester.pdm-sandbox.io -s --skip443 --skiptcp; then echo "Failed to run edge-testnet -d example.com with SNAP env defined"