Offset and limit getDatasetDifferentialExpressionAnalyses endpoint #841
Labels
Milestone
Comments
|
That's right, it's completely superfluous. |
arteymix
added a commit
that referenced
this issue
Sep 15, 2023
… analysis VOs Remove unnecessary offset/limit parameters of getDatasetDifferentialExpressionAnalyses() (fix #841). Add a parameter to include analyses of subsets. Tidy up the DAO: - don't retrieve FVs for subsets if includeAnalysesOfSubsets is false - initialize proxies of both experiments and subsets Include analyses of subsets in the output of the endpoint. Add two new service methods to retrieve analysis VOs: one by a collection of BioAssaySet and another one for a single BioAssaySet. Use the latter for the REST API. Rename sourceExperiment to sourceExperimentId and retain the older name marked as deprecated (fix #844).
arteymix
added a commit
that referenced
this issue
Sep 15, 2023
… analysis VOs Remove unnecessary offset/limit parameters of getDatasetDifferentialExpressionAnalyses() (fix #841). Add a parameter to include analyses of subsets. Tidy up the DAO: - don't retrieve FVs for subsets if includeAnalysesOfSubsets is false - initialize proxies of both experiments and subsets Include analyses of subsets in the output of the endpoint. Add two new service methods to retrieve analysis VOs: one by a collection of BioAssaySet and another one for a single BioAssaySet. Use the latter for the REST API. Rename sourceExperiment to sourceExperimentId and retain the older name marked as deprecated (fix #844).
arteymix
added a commit
that referenced
this issue
Sep 20, 2023
… analysis VOs Remove unnecessary offset/limit parameters of getDatasetDifferentialExpressionAnalyses() (fix #841). Add a parameter to include analyses of subsets. Tidy up the DAO: - don't retrieve FVs for subsets if includeAnalysesOfSubsets is false - initialize proxies of both experiments and subsets Include analyses of subsets in the output of the endpoint. Add two new service methods to retrieve analysis VOs: one by a collection of BioAssaySet and another one for a single BioAssaySet. Use the latter for the REST API. Rename sourceExperiment to sourceExperimentId and retain the older name marked as deprecated (fix #844).
|
Implementation is in #859. I'm getting rid of offset/limit altogether and adding a parameter for including analyses of subsets in the output. |
arteymix
added
rest-api
oganm
added a commit
to PavlidisLab/gemma.R
that referenced
this issue
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am a bit unclear on what offset and limit arguments are doing in this enpoint. It seems like unlike all other enpdoints with an offset and limit, they don't provide a
totalElementscomponent and this probably makes sense because they always return data from a single experiment as a single object which also makes these arguments entirely pointless as far as I can see.The example here shows the lack of difference that comes from specifying a limit to one experiment with multiple resultSets and contrasts that may have been subject to the limit albeit likely not very usefully
https://gemma.msl.ubc.ca/rest/v2/datasets/12709/analyses/differential
https://gemma.msl.ubc.ca/rest/v2/datasets/12709/analyses/differential?limit=1
The text was updated successfully, but these errors were encountered: