Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL filtering applied via HQL/SQL do not account for entries inheritance #1013

Closed
1 task
arteymix opened this issue Jan 31, 2024 · 2 comments
Closed
1 task

Comments

@arteymix
Copy link
Member

arteymix commented Jan 31, 2024

Entities that can inherit ACEs are not properly treated by the generated HQL/SQL.

The challenging part is they may require an arbitrary number of jointures to traverse the ancestry, though in practice we only ever need to look at one or two parents.

The best example is a DEA performed on a subset: the analysis has the subset as a parent which in turn has a complete EE as parent. The ACEs are stored in the EE, requiring two level of indirection to get the appropriate permissions.

  • warn or produce an error when an entity that is retrieved inherits its entries
@arteymix
Copy link
Member Author

arteymix commented Feb 1, 2024

I'll mark this as low priority because it does not impact AD and EE filtering (except for subsets).

@arteymix
Copy link
Member Author

arteymix commented Feb 1, 2024

This is fixed in two ways: first we don't allow SecuredChild to be subject to ACL filtering anymore (see 3d7ac36) and second we do not assign ACEs on children and will add a linter for this in #997.

@arteymix arteymix closed this as completed Feb 1, 2024
@arteymix arteymix added this to the 1.31.1 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant