From 63a2fd4aef4eb3d2da9e8cc75f15542ce9c74c48 Mon Sep 17 00:00:00 2001 From: Paolo Patierno Date: Thu, 10 Oct 2024 05:55:02 +0200 Subject: [PATCH] Minor refactoring for IDE warnings (#10692) Signed-off-by: Paolo Patierno --- .../operator/assembly/KafkaRebalanceAssemblyOperator.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java b/cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java index 212721f6736..011a9723e8c 100644 --- a/cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java +++ b/cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java @@ -146,13 +146,13 @@ public class KafkaRebalanceAssemblyOperator private static final ReconciliationLogger LOGGER = ReconciliationLogger.create(KafkaRebalanceAssemblyOperator.class.getName()); - protected static final String BROKER_LOAD_KEY = "brokerLoad.json"; + /* test */ static final String BROKER_LOAD_KEY = "brokerLoad.json"; private final CrdOperator kafkaRebalanceOperator; private final CrdOperator kafkaOperator; private final SecretOperator secretOperations; private final LabelSelector kafkaSelector; private final ConfigMapOperator configMapOperator; - private int cruiseControlPort; + private final int cruiseControlPort; /** * @param vertx The Vertx instance @@ -420,8 +420,7 @@ && rawRebalanceAnnotation(kafkaRebalance) == null) { } private KafkaRebalanceStatus buildRebalanceStatusFromPreviousStatus(KafkaRebalanceStatus currentStatus, Set validation) { - List conditions = new ArrayList<>(); - conditions.addAll(validation); + List conditions = new ArrayList<>(validation); Condition currentState = KafkaRebalanceUtils.rebalanceStateCondition(currentStatus); conditions.add(currentState); return new KafkaRebalanceStatusBuilder()