Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elemental overload not reducing ailment chance to 0 #8325

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Sep 28, 2024

Fixes #8137

Description of the problem being solved:

Currently it seems the "Ailments never count as being from Critical Strikes" mod line found on the Elemental Overload keystone is implemented by simply never running the crit calculation pass when calculating ailments. This causes the ailment chance to still show up in the breakdown and cause issues with the Perfect Agony keystone which makes ailments only apply from crits.

Marking this as draft for now as this could really use a review by someone more familiar with ailment calculations.

Link to a build that showcases this PR:

eNq9XOtz4jgS_zz5K1xU7acjAT8wJpXsFnlNchsmHGRm7u7LlmIL8EZYjC0nw2zt_34tyS8YZGxM3c5WBqz-9UvdLanlzMVv35dEe8Nh5NPgsqWfdVsaDlzq-cH8svX5-e7Uaf3268nFGLHF0-wq9gkf-fXkw4X4rBH8hslly-i1NIbCOWZfUlbmH8BqhQK2wDQYoT9p-JF6l61PNMAt7QUFns_Sby5BUfQJLfFla-oCuKWhyMWBd50_TwgXKEQuw-EjFzuMGR1RD0ZniEQwvER-MKXuK2YfQxqvwJyW9ubjd0n0MBo_TZ4LOvlBUSew6cPFmKA1DqcMMS2CH5etIbgGzfENWsJP4IZIDKx6un2mD_RWpxR0FYcRq4ecrjD2MmL9zLINR0U7DvHtbIZd5r_h69Bn1wsUuLkkkKNC7qDWz3qOXUY_ignzV8THYY5R0d__xN5Q8n6mDJGb8TQj7fd6Z13H0geWU46hLMN0VZRffba4IuDTmhI47mEe-AwfABxTP6LBgTYVYUqzrmNCIA0r0U5whMM3xPxNldS86fLFD2p7bBhi9DSTATlBnh9HI8xCHOUhoI7HEQrQNY3y-dStMtIxDqE6sA1Edw9gil0KBaUIMbpnVn9gVJC0G68U-ejPcHXKWtYkgLraHGbH7bQqXW3Ghyk0gUpajXJKY1KRkoWFiFAn0bcNQjXlDf6eh3G3jOEGpa5MjoegkBd6GcMipe2oFXyjTCyy-1wjStLt_Tg324T9gWGYg67R09WZM16sI99FZIS--8t4CavBM3rFuUBTXUUe_fmCBVDaVFhDN1XYOz_EB8CuKfEOgS0QjdQ4R11W_OAedj9D141hL7POMWVemeEq3oPdg3vOiR8Ct1ph-ByEYnkobDrMcj0mkK98e_NCcFVILiRJ-yoJImXNcZAIzB1lnvXKQI8Yu4uP4OUJYrja-pDPwcAu9S0nLvrWKF2ndji3RMAmooanOHC3p5wzswxU01O3AQ7n6-nCx8SrR50qdo1WFQoyd3QRXSmYN8XtckYlaE2XfEWhV23ZqqvTG4qKNVovz_mEvJKnRhj2wwDw8NYevas-aNA_-TGD1IMNwyWNw4oTLokrGZAuL_JkNcFe7FZbz7LT0hWBQ2JVMzIU6ElILeiQMeS-3lBvXtlpQkgtxKZ-03i1ghrCo6EqA75uwiHBL-yWTu0K1E8QypUymq-w1QXk1JUFZLuG6lK2INVt4ct-DWNy8soisgkdQbFYwiIgmgIjWuwLdJVL4B0cDSud8wRhxfPmmL6D8gve4InqUcMOKV-4laqEOPixrsx_g7ySgNvAg80WZENlGduIXWKe_SXU0ii6QQxpXrKt_oJCHwXMEM2nCKPQXTzC7N8hQl6gGFy2ik_FN9GwuvMJw-ENPONCuWLbHPW04XLREa03_ulhuaIh0_B3_tcYhWyd9sIEoXgCfCLmB6IBACWJkJY2XdD3offGJT1TSqKsgYZWKxx4GzyeQ4w1lBYYlyshjOdftCWKQOu1jNiIW1No3D14woyAggKXrb7pOG1rMOg7bbNvD7ptw7S6_bbVs3p2u-c4ptm2-nCsaJsDx4afJpzN272B3bXblmMZZrvXM02jbTi9vgWjAGvb5qAPWL3v2G3dApChA97qd22gs6yB3XYGptPWuxaIs42u1YZzG9fCBtFty-jb3XbP1ntm2-6C1Lau247Dp4efSFG4Hm7aEvjgOgbuKLQ4ed_TzY3lnvlw8XnyKD58WDC2is47nff397MVYgs6w99hFT1z6bKzAhD49DR69Qk55Ww7Q_jvaj4c3l_9cN9_fHt-Iuwt-u-19dqL9Xk0o3rYDYzryVtAR_88xX_-Pp1_1a8_YlMnp-8PMaWni7nz5dXXr353Hww9CPu-QYHlpVCqk2p1ITukUUd-42Up9GGKZEx3-LyKIOMTzz98ogxHfIw_TL9cTLnaEQRvyD7iZXS1hjpyx3dQWw2kJHI49RQzmRRFzGWLhTHmwT5DMeHP_xUj4vNA7hafPso-c0DDZXawBFYQyHzFkxyf1yseacPHRzkyJCxhxsWlUS2jN1FI8700opOHook8zLW-RsSNhN5-4JLYg7NVUmKzrCHohevGG-f8WOSlNm1xygR9uAB9EuKPhL4gYqQQEQ08bXOxaYcd3DHHSx5nI8yQBzWn88DArg43riMkwKfp0pcbV1EzOHXyRHAufP9WcHMmVQhMRjjtjfR_a0NZPVV2y1yXxoHkEKBlUiyksM4-syvamM30I1RdHMo-66axkkRufRhNKXLji-PP2fj_xxlSqsaolshNUlBOXpJ-SWCKFJRJxj-KcBAUD8EqZoLpZWvpR-4fL_Fsxi84QHMWilub27u72-vnhy-3yTpVhAjr_gji5Qtv5Mu_807-FIuttBbFL5H8eNn64uN3ocgNTIlPIm4bIWgV4WyhEFmUaE4AV8JNUN372bXIbl45gZrT7Xccwro2hzOYG_pYqVc2vkcpKZCfz_i6ruLGbx3UjOSG_xpWRXl-VHhKXPKoufDrFqU5fLAECzsCRJSSk9E9nmC8jkLE-jPf5Vui8innVVdSlfgla3Yp5zs5rah5iGscFQM5qAanib4bXUzH3V4VV0FKr8pRNfwGu0hpuxxUg7OWBA3ATSouGVUJp080EEEOSTP0CT9ZKGf2luCMRM3wiS1wmGz-VJxGUKNSktLECf2XmKnTuEBR4ivRKFV4iI-pobIPqLCBj5VUoo3GmMKhRRo1K9lQUhayMqg8ZSr9l5xZS6Ygadco3C9HS5yQdqwU9ifDJUki6u_wjfqe7Fso0mWLrKxgwEa3ORvRjGnOZrs705zjHZw7XpXznYyq4Z-Zz3c2O7jIHUwlJjypmnHgudWMwzNszFkc4oMZTLZ3Ijl2Ur4HydoJO8HpaFnlSLoMB3OQvZCD4aJVczBa1H_YFmOwoHQByGhK8oPFwQ04g5XkRkVWQq3dhSS3rhYvuRTutLQ2R5ngyX1hWQ2QJHsYwVp-X7JbrMYp6zjeY0T4-yuUNGP4071oE2b81iReocBL2T3t2qPn81DRe5RFwFO00m745UxTHwZ4ud7BSK3XRSc91YkmGz9nJa3BKQt5O-EHpcv_wOGs3z-znK7l6OJ_-Tzph1hJDwT23zc-zGIooi-Vygn_fdk61R39TNf7GQchXRysk_4M_5y1Z9T84gjL1zW-YrSigUAUmiqcS7GhMoFzOVufa5Ph5PYEdpQ8hxDR9HtthFx8coUXeEnZQn67DtGMYe9c46JOxiGe-d_Ptb-gOs7xefes9_cjdREZeh72-BWEdKZTTsivEioRZrcBKfUUDtW7qB8CN8QIJlae9MRJzlRS87Mav6mC-fRfkwud_dT5m3bWSdK_OteM7knStwN_nsKfExEBE_ztXOt3T-BgR3zX56P6yV8MzaNzJDRsR1zFv-1fePtKqq5J3TWh_AnYHwEH3pXQza7GfatJL8gh2xJDel_j3twY0g0-ZOimlvkvHdcNpUBjYyg1WpM-0qSTTv5h9H_hzGWT5Seq3EWigTKi3oT7UhMevWyBS1tJICYtFiWFsZfC3Eth7aXo7aWw91L0k-IjOmJZvvEepjotN9ubhDINDqrL8cvnySMvMLIlBD5-44saH5Jt7E45QIrR9Byi74NcUSi32vBlHUV8FkUka70aMq8wYdt4owZebAI18wArtek7Wm2Ltg5h1MD8hIdxBB67DbKPYJB9BIMO4rHLIL1OcO2KTvMIHjGOZU2deLvHsFtljfyxI9nsxhoYtTk0Fmkey_-9IwSDfoT00I-gh1UzEo5VYoymGWkdwYH114yjlVizqf1GwxSup4C31mTTr0kMyr1FEw67E7vXmIN9rGnVj1Vj6odmcz9ajeeyd5ygqmP8cBkTzI5QCc0jFBSzYVJaDfH6cfx_8EpZO2it2ohDdlENvdprWquPNC3WsYrL0fbVBx-hauAmvJNgNC5NxnHm4GgrxTEOfNZhNtV1fvM1_kibjV5jRZovcXbdYtC0ePwsUHZ95HtBvF2MPDwVreKvmLfeItlPFi1d8boQDWb-PGnuyi9Je1fgsyca8xnBhVebiv2iMUEuXlDi4TBRFvMed_IryumrQ_1uZqMCsPHKdAoz96G2WrI50jAsfZ_Ewu83p7DeHkzxLfgMs9e0rMFcS7-8gV0LJjq-OcKx1PTLrEHKfyEZh9ibijeT-FtpU0xmhVe_ehVsrO2YbPbG_PYnm_SqqPoTwWNs26XOwN4Dy15ayLzR1S2zQnRtizKrREpVX0xdKi6BYMKin97RU0pIfh2GEiL6x8UM3YNMl4gUYOsDZ6DGRP7cJ08zcXUMSor776pKbv7uTu2kqezBBRRShQMvOln5k5dw4tuvJxed7X_j4n9qMF3l

Currently, it seems the "Ailments never count as being from Critical
Strikes" mod line found on the Elemental Overload keystone is
implemented by simply never running the crit calculation pass when
calculating ailments. This causes the ailment chance to still show up
in the breakdown and cause issues with the Perfect Agony keystone which
makes ailments only apply from crits.
@Paliak Paliak added the bug: calculation Numerical differences label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elemental Overload combined with Perfect Agony should prevent ailments from hits
1 participant