Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foreground FPS limit #16

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Mar 15, 2021

  1. Add foreground FPS limit

    As reported in issue PathOfBuildingCommunity#13, PoB tends to use significant CPU and GPU resources
    while in the foreground. This change exposes a foreground frame rate limit that
    can be configured via a CVar (vid_fgfps) that defaults to a 30 FPS limit and
    allows a 5-120 FPS range. A setting of 30 feels responsive and reduces the
    resource usage by a modest amount. CPU usage hovers around 4% on my 16-core
    system with this change, as opposed to 6% usage with the current build.
    Similarly, GPU usage hovers around 18-20% with the 30 FPS limit and around
    25-28% with the current build.
    
    There may be a better place to situate the sleep that is introduced for this,
    but this seemed like a reasonable place for someone who is not very familiar
    with this code.
    
    I also removed the reference to tiff.lib in the Debug configuration since that
    is unused and not a vcpkg dependency.
    mweber15 committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    aa7fbd0 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Revert tiff.lib removal

    mweber15 committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    2dec793 View commit details
    Browse the repository at this point in the history
  2. Incorporate review feedback

    mweber15 committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ab3f87d View commit details
    Browse the repository at this point in the history
  3. Formatting

    mweber15 committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9f28e3e View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2021

  1. Configuration menu
    Copy the full SHA
    164da20 View commit details
    Browse the repository at this point in the history