Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement Adding Social Handle Commands on Save in Info Panel #58

Open
Param302 opened this issue May 26, 2024 · 2 comments
Open
Assignees
Labels
Code Coding issues enhancement New feature or request

Comments

@Param302
Copy link
Owner

Implement Adding Social Handle Commands on Save in Info Panel

Overview

You have to implement functionality of adding commands in commands table under Info panel which displays the commands of links entered whenever user clicks Save button in Edit panel.

image
image

Requirements

  • After adding some links in Edit panel, whenever user clicks Save button, it should add commands of those social handles in commands table under Info panel.
  • It should only add commands of those social handles of those links which are completed.
    • A link is completed, when there's no bottom line present below the link in Edit panel.
    • 2nd link shown in first image is completed link, others are invalid/incompleted links.
    • You can use isValidURL() function from index.js to check whether a link is valid or not.
    • Or you can check for CSS styling too, both should work.
  • It should create the command row save as provided in 2nd image.
  • The command row must have two columns, 1st is command name, which is same as the Social media name with a \ prefix and 2nd is Social media name.
  • It should have same design and layout as shown in 2nd image.
  • For creating the command row, you can use createSocialLink(key, value) function from index.js, where key can be retrieve from socialLinks object, which is the name of Social media and value should be same as the provided link in input element of link-box in Edit panel.
  • Must follow the Code Guidelines provided.
  • To test the code, setup the extension by following these steps.
  • All the functionality should be implemented in index.js only.

Structure

  • Structure of a command row is provided below and you have to create the layout as it is but in JavaScript, don't use this a template, rather use Javascript document.createElement() function to create elements.
     <tr>
         <td><span class="cmd">\twitter</span></td>
         <td>Twitter</td>
     </tr>

If you have any suggestion or idea, you're welcome to share.

Let's implement SocialRepo's save button functionality! 🙌

@Param302 Param302 added enhancement New feature or request Code Coding issues labels May 26, 2024
@rajat4984
Copy link

Hi @Param302 , i would like to work on this issue. Can you please assign it to me.

@Param302
Copy link
Owner Author

Param302 commented Jun 5, 2024

Hi @Param302 , i would like to work on this issue. Can you please assign it to me.

Sure @rajat4984 ,

Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Coding issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants