Bugfix #1
Open
Bugfix #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default template parameter of `uniform_int_distribution` is int. As the constructor uses the same type, the passed argument `window` will be implicitly narrowed down and get overflow when its value is greater than INT_MAX. In that case, the random number generator has UB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniform distribution
Invoking
uniform_input_unsorted(n,4294967295)resulted in callingstd::uniform_int_distribution<int>(1,-1), which is an undefined behavior. Fixed it by changing the type tostd::uniform_int_distribution<size_t>.--small flag
parser.add_argument('--small', action="store_false", ...)assigned a default value toargs.smallso the scripts would always use the small datasets regardless of--smallflag. Besides,store_falseseemed to have the opposite behavior to the literal meaning of this flag.