Vanilla end teleportation #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player should be teleported to Vec3.atBottomCenterOf(targetPos.below()); Other entities should be teleported to Vec3.atBottomCenterOf(targetPos); And end-teleportation keep velocity (this.getDeltaMovement)
sofianedjerbi
force-pushed
the
fix/end-teleportation
branch
from
85ad6b0
to
3446561
Compare
|
The changes were done to mirror the player teleportation logic for all entities. This is why the velocity is set to zero and why they are all teleported to the bottom. Is there any reason this behavior is bad? |
|
Settings velocity to 0 & position to platform might break some wither + snowball obsidian farms |
Euphillya
added a commit
to Euphillya/TenseiMC
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player should be teleported to Vec3.atBottomCenterOf(targetPos.below());
Other entities should be teleported to Vec3.atBottomCenterOf(targetPos);
And end-teleportation keep velocity (this.getDeltaMovement)