Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project dependencies may have API risk issues #21

Open
PyDeps opened this issue Oct 25, 2022 · 1 comment
Open

Project dependencies may have API risk issues #21

PyDeps opened this issue Oct 25, 2022 · 1 comment

Comments

@PyDeps
Copy link

PyDeps commented Oct 25, 2022

Hi, In Advanced-Deep-Learning-with-Keras, inappropriate dependency versioning constraints can cause risks.

Below are the dependencies and version constraints that the project is using

numpy
scipy
Pillow
matplotlib
scikit-image
tensorflow-gpu
h5py
graphviz
pydot
pydot_ng
tensorflow-addons
termcolor
gym
tensorflow-probability

The version constraint == will introduce the risk of dependency conflicts because the scope of dependencies is too strict.
The version constraint No Upper Bound and * will introduce the risk of the missing API Error because the latest version of the dependencies may remove some APIs.

After further analysis, in this project,
The version constraint of dependency numpy can be changed to >=1.8.0,<=1.23.0rc3.
The version constraint of dependency scipy can be changed to >=0.10.0,<=1.8.1.
The version constraint of dependency Pillow can be changed to ==9.2.0.
The version constraint of dependency Pillow can be changed to >=2.0.0,<=9.1.1.
The version constraint of dependency matplotlib can be changed to >=0.86,<=0.86.2.
The version constraint of dependency matplotlib can be changed to >=1.3.0,<=3.0.3.
The version constraint of dependency scikit-image can be changed to >=0.9.0,<=0.11.3.

The above modification suggestions can reduce the dependency conflicts as much as possible,
and introduce the latest version as much as possible without calling Error in the projects.

The invocation of the current project includes all the following methods.

The calling methods from the numpy
numpy.linalg.pinv
The calling methods from the scipy
scipy.stats.contingency.margins
The calling methods from the Pillow
PIL.Image.fromarray
The calling methods from the matplotlib
matplotlib.patches.Rectangle
matplotlib.lines.Line2D
The calling methods from the scikit-image
skimage.util.random_noise
skimage.img_as_float

@developer
Could please help me check this issue?
May I pull a request to fix it?
Thank you very much.

@roatienza
Copy link
Collaborator

Sure. Pls submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants