Init of the Couchbasev4 extension

[Geolim4]

Follow up of the initial pull request on main Phpfastcache's repository.
Ping @srjlewis srjlewis

[Geolim4]

Please also make a check of the PHP extension to make sure that at least the 4.0 is used for this driver.

[Geolim4]

Damn, I missed the part of the code you made for this:

couchbasev4-extension/lib/Phpfastcache/Drivers/Couchbasev4/Driver.php

Line 70 in aed42f0

$extVersion = (new ReflectionExtension('couchbase'))->getVersion();

You can simplify it using str_starts_with on '4.' string :P

[srjlewis]

lol I could of done be went all the way

[srjlewis]

I am going to get this pulled into my framework, put it to work and add some of my latest changes.

Main change is to the Config class, I have removed the proxing to the ClusterOptions, it looked like a good idea at the time, but over complex for documentaion, maintaince etc.

I will also added most of the changes from 9.2

[Geolim4]

I'm gonna push some changes to the main repo for the extension mechanism.

[Geolim4]

PHPSocialNetwork/phpfastcache@e0223f0

[Geolim4]

If things work properly:

couchbasev4-extension/lib/ExtensionRegister.php

Line 7 in 8f854ad

PhpfastcacheExtensionManager::registerExtension('Couchbasev4', Driver::class);

The file is auto-loaded automatically and will register the extension to the ExtensionManager.

Then the CacheManager will be able to automatically discover and load the extension:
https://github.com/PHPSocialNetwork/phpfastcache/blob/e0223f0822f514d4f1df5867333b664b4c147c3f/lib/Phpfastcache/CacheManager.php#L119

[srjlewis]

I was just reading through the commits, I will be doing a intergration with it tomorrow to see how every thing goes, so fingers crossed it will go smoothly, I do like the extention model concept has it removes a load of requires from composer, which are not needed if you are not useing those drivers.

[Geolim4]

That's why I put a lot of dependencies as "suggest" until now (the require list push was an error).

[srjlewis]

oppps, I pretend I did not see it 🫣

[Geolim4]

For more consitency, extension version will have the same version than Phpfastcache.

So technically phpfastcache/couchbasev4-extension will starts at v9.2.0-alpha (which I just pushed the tag).

[srjlewis]

Yes that makes sense to begin with, but going forward are we going to retag each extention on each release of the core, even if there has been no changes to the driver/extention, and what all we need to do is a update to a extention with out the need for a release of the core.

[Geolim4]

I don't plan to go that far. Only to restrict extensions to each MAJOR versions of phpfastcache.
A 9.2.1 version of Phpfastcacge will not necessarily trigger a 9.2.1 of phpfastcache/couchbasev4-extension as Phpfastcache lib is SEMVER compliant. However a retag will be necessary if the major version of Phpfastcache is released :)

phpfastcache/couchbasev4-extension will follow its own versions, but the major version will follow the Phpfastcache core.

[Geolim4]

That's why I released an API Changelog years ago:

https://github.com/PHPSocialNetwork/phpfastcache/blob/master/CHANGELOG_API.md

To display public interfaces changes that could breaks compatibility between each MAJOR versions.

[srjlewis]

Yes total agree, that makes much more sense

[Geolim4]

For now I don't know how to make the test suite working for this extension, I need to see if I can reuse the tests lib from Phpfastcache and if I can make a Gitlab Action test suite with Couchbasev4

[Geolim4]

I added webmozart/assert as a dev dep so you can make simple tests for Github Actions.

[Geolim4]

I finally took time to setup the Github Action 🥳
https://github.com/PHPSocialNetwork/couchbasev4-extension/actions/runs/7428265248/job/20215339882

[Geolim4]

I just pushed a commit to make those extensions requirements optional but required with the doPosixCheck config:
fd8f2fe

[Geolim4]

It's late night but I finally managed to split up my test tools into a separate repository so I can use it both in core and extensions repos :D
Gotta go sleep now !

[srjlewis]

Morning, sorry I was not about last night (I had family stuff to do)

I did what to use the existing test tools, but I could not pull them in, So I am glad you have split the test tools out and removed the messy test code :)

You beat me the the setDoPosixCheck, I was going to use something on the lines of setForkDetection has it would be more descriptive of what is does, let me know if you are fine with me changing it.

Yes I have used git actions before, but internally at work we use gitlab and it's runners which I know better.

[Geolim4]

You beat me the the setDoPosixCheck, I was going to use something on the lines of setForkDetection has it would be more descriptive of what is does, let me know if you are fine with me changing it.

Feel free to improve it as I'm unable to test the extension locally atm :)

[srjlewis]

I will do the changes a bit later when back near my computer, I just want to finalise the Config API before release :)

[Geolim4]

I plan to release the 9.2 for both the core and the extension for 10 January, just so you know :P

[srjlewis]

Here is a recording of all the permissions

Screen.Recording.2024-01-06.at.21.53.27.mov

[Geolim4]

That's effectively completely different that the permissions I have in community edition indeed:

[srjlewis]

oh yes they are, if I set read and write only, the user wont be able to flush even if the flushEnabled() returns true, you only find out when you try and run the command with a nasty ServerInternal exception with a message about permissions, hence the try catch.

[Geolim4]

That means even the driverWrite() and driverDelete() could be impacted too.
But tbh I don't think we need to go that far, catching the flush operation is enough IMO, if there's Exceptions, they will be explicit enough for the user to make the needed changes to Couchbase server configuration.

[srjlewis]

I competely agree and that is why I did not put any handling in the driverWrite() and driverDelete() calls.

[srjlewis]

I have put in a test thats tests the lockup of the extention, so hopfully if/when Couchbase fixes it, it will flag it up to us.

[Geolim4]

Thanks, judging by the date you created the issue on their tracker, they don't look urged to fix it ? :(

[Geolim4]

@srjlewis what is the compatibility threshold limit of Couchbase v3 ? PHP 8.2 or PHP 8.3 ?

[Geolim4]

That’s fine and understandable if you happy with it skipping on PHP 8.3, I have never been keen on travis a lot of people are dropping it.

I'm not surprised: they removed the ability to use their free services automatically, you have to periodically get in touch with their support to ask for a resupply of 25k min of OSS credit. For Phpfastcache project this credit is spent between 4 and 6 month, imagine for bigger projects.
Also when Github shipped Actions, it was like an earthquake for the Open Source community. Because it is easier to setup, more reliable (travis builds fail a lot sometime for no reasons...), more UI-friendly and the better for the end: Better integrated to the GitHub environment.

I kept both CI services until now for two reasons: Scalability (if one service fails I can rely on another) and because I was afraid of the youthfulness of GitHub action, but there's clearly no reason for me to keep them both anymore, it simply costs me time and brain energy which are both resources that I don't overflow 😂

[srjlewis]

🤣 I don’t think I could have put it better myself.

[Geolim4]

And yet, knowing you're a fellow England neighbor, I still struggle to write you my best English without making your eyes bleed 😂

[srjlewis]

Hey your english is better then mine 🤣🤣🤣

[Geolim4]

I'm touched 👉👈 ☺️

[Geolim4]

@srjlewis I made a change that I'd like to bring to your attention:
b8f4a38

I will make the same mechanism for the all extensions.

Since I found a way to make it SEMVER-compliant I will ship all the extensions for the v9.2.
But they will be composer-required for v9.2, then removed from dependency as of Phpfastcache v10.

This way the changes will remains completely transparent for the developers.

[srjlewis]

I will have a look around, I guess the release got rescheduled from the 10th 🤣 , I will keep a eye out for any issuess, and ping me if you need anything.

[Geolim4]

Thank you, i'd say, feel free to test Arangodb/Mongodb/Couchdb extensions if you have free time ahead :P

[srjlewis]

when I have a bit of free time I will spin up some VMs in our dev environment, and see if I can switch KV stores without any of my dev's noticing.

[Geolim4]

Today I was on a good mood and I created this gem in a couple of hours x)

(It's still on beta stage for now)
https://github.com/PHPSocialNetwork/ravendb-extension

[srjlewis]

😁 I do think the extensions are making it a lot more manageable, because you have testing, code and even the docs for each driver on it’s own. And when you do create a new driver it be developed and released without affecting any other parts. But you already know all of that anyway.

I will see if I can test the new extension a bit quicker for you.