Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll refactor #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Jekyll refactor #19

wants to merge 3 commits into from

Conversation

afilina
Copy link
Collaborator

@afilina afilina commented Mar 30, 2021

Fixes #12

Additional changes:

  • The phpunit.xml.dist was out of sync with the used version of PHPUnit
  • Simplify existing tests
  • Remove an unnecessary execution path
  • In addition to removing extra LF, also remove extra CRLF

@afilina afilina requested a review from jrfnl March 30, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create separate implementations instead of extending
1 participant