Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made status bar transparent #158

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dhruv-porwal
Copy link

@dhruv-porwal dhruv-porwal commented Feb 27, 2023

Made status bar transparent to look more professional.

Description

Describe the changes you have made.

Issue Resolved

Link to the issue that is resolved by this pull request goes here e.g. Fixes #10.

Screenshots

Provide some screenshots of the changes made (if applicable).

Checklist

Please make sure to review the following before submitting your PR:

  • I have read the contribution guidelines.
  • I have read the code of conduct.
  • I have reviewed my submission in detail.

Made status bar transparent to look more professional.
@ken1000minus7
Copy link
Collaborator

Can you share a screeenshot of the app after the changes

@dhruv-porwal
Copy link
Author

dhruv-porwal commented Feb 27, 2023

Can you share a screeenshot of the app after the changes

Screenshot_20230227_140813_MovieDroid

@ken1000minus7
Copy link
Collaborator

Seems fine, can you share one in light mode as well

@dhruv-porwal
Copy link
Author

Can you share a screeenshot of the app after the changes

Screenshot_20230227_140813_MovieDroid

This is after changes

@ken1000minus7
Copy link
Collaborator

can you share one in light mode as well

@dhruv-porwal
Copy link
Author

can you share one in light mode as well

Uploading Screenshot_20230227_151027_MovieDroid.jpg…

@dhruv-porwal
Copy link
Author

can you share one in light mode as well

Screenshot_20230227_151027_MovieDroid

@dhruv-porwal
Copy link
Author

can you share one in light mode as well

Screenshot_20230227_151027_MovieDroid

Sir in light mode for your reference

Copy link
Collaborator

@ken1000minus7 ken1000minus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color u hv applied on the status bar #000000 is black and not transparent

Copy link
Author

@dhruv-porwal dhruv-porwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir now it should work.

Actually color code for fully transparent is #00000000

@ken1000minus7
Copy link
Collaborator

Share a screenshot

@ken1000minus7
Copy link
Collaborator

Please a share screenshot to show your changes, otherwise I won't be merging this pr

@dhruv-porwal
Copy link
Author

OK I would share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants