Fix keyed services key type #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 15, 2024 21:52
rinkeb
changed the title
|
Thanks, @rinkeb! I'll clone it this weekend and run through some tests. Does this only affect Orleans 8 (not 7)? |
|
Nice! Does this only affect Orleans 8 (not 7)? Not sure. I started using the testkit just recently, already on Orleans 8. AFAIK keyed services keys have been of type |
|
I believe the regression issue with keyed services has been introduced in
.NET 8.
…On Tue, 24 Sept 2024, 20:55 Rinke, ***@***.***> wrote:
Nice!
*Does this only affect Orleans 8 (not 7)?*
Not sure. I started using the testkit just recently, already on Orleans 8.
AFAIK keyed services keys have been of type object? since introduction in
.net
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANRND4MVWRRVMLIB5EWVCTZYG7SXAVCNFSM6AAAAABOIDIBH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZSGI2DQNRYHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@rinkeb I added a few more overloads to facilitate keyed service registration and added some unit tests. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of the key in
AddKeyedServiceisstring, but should probably beobject?to match_keyedServicesandGetKeyedService.This allows for testing/mocking grain dependencies registered as a keyed service with another key type (for example
int).In addition, make the key param name consistent with
GetKeyedServiceandIKeyedServiceProvider.