Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose of GrainCancellationTokenSource #59

Open
hendrikdevloed opened this issue Mar 18, 2024 · 1 comment
Open

Dispose of GrainCancellationTokenSource #59

hendrikdevloed opened this issue Mar 18, 2024 · 1 comment

Comments

@hendrikdevloed
Copy link

Given that

public sealed class GrainCancellationTokenSource : IDisposable

Should

var token = new GrainCancellationTokenSource().Token;

become

        using var cts = new GrainCancellationTokenSource();
        return await Start(request, cts.Token);

?

@Kritner
Copy link
Member

Kritner commented Mar 19, 2024

I'm not totally sure if this needs to be done or not... would the source stay in scope for the full duration of the sync work progressing? would need to do some testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants