Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user dependency on Jaylib #2

Open
Yeffian opened this issue Mar 17, 2022 · 2 comments
Open

Remove user dependency on Jaylib #2

Yeffian opened this issue Mar 17, 2022 · 2 comments
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed question Further information is requested

Comments

@Yeffian
Copy link
Member

Yeffian commented Mar 17, 2022

Currently, to work with Orbital properly, you need to add the Jaylib dependencies separately and use Jaylib specific classes. This can be solved by implementing wrapper classes around all Jaylib classes, so the need for the users to add Jaylib is eliminated.

@Yeffian
Copy link
Member Author

Yeffian commented Mar 28, 2022

With the implementation of Vector2f and Color classes and enums, i think this is basically done.

@Yeffian Yeffian closed this as completed Mar 28, 2022
@Yeffian Yeffian reopened this Apr 2, 2022
@Yeffian
Copy link
Member Author

Yeffian commented Apr 2, 2022

So it turns out its not! You no longer need to use Jaylib classes, but you still need to include jaylib as a dependancy. My solution to this was to use shadowjar and make it a fat jar, but that does not seem to work. Requires some further research.

@Yeffian Yeffian added bug Something isn't working help wanted Extra attention is needed question Further information is requested hacktoberfest labels Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant