Correct HS Time Calculation and Print Statements #15005
Merged
+64
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
<!-- Thanks for taking the time to open a pull request! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview Concise print statements and HS on time calculation correction. # Test Plan Tested on ABR robots. # Changelog Previously, the heater shaker temperature on time was linked to the shaker on time. This has been corrected to reference the correct command string. If the heatershaker is not deactivated, the on time is calculated with the protocol end time stamp. Changed print statements for get robot logs and abr_google_drive to make it more obvious to the user if there is an error or not. # Review requests <!-- Describe any requests for your reviewers here. --> # Risk assessment <!-- Carefully go over your pull request and look at the other parts of the codebase it may affect. Look for the possibility, even if you think it's small, that your change may affect some other part of the system - for instance, changing return tip behavior in protocol may also change the behavior of labware calibration. Identify the other parts of the system your codebase may affect, so that in addition to your own review and testing, other people who may not have the system internalized as much as you can focus their attention and testing there. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Concise print statements and HS on time calculation correction.
Test Plan
Tested on ABR robots.
Changelog
Previously, the heater shaker temperature on time was linked to the shaker on time. This has been corrected to reference the correct command string. If the heatershaker is not deactivated, the on time is calculated with the protocol end time stamp.
Changed print statements for get robot logs and abr_google_drive to make it more obvious to the user if there is an error or not.
Review requests
Risk assessment