Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: failing tests in _tests/erc721-consecutive.rs_ #286

Closed
2 of 4 tasks
0xNeshi opened this issue Sep 16, 2024 · 3 comments
Closed
2 of 4 tasks

[Bug]: failing tests in _tests/erc721-consecutive.rs_ #286

0xNeshi opened this issue Sep 16, 2024 · 3 comments
Labels
needs triage Needs to be assigned the appropriate labels type: bug Something is not working as intended.

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Sep 16, 2024

What happened?

Followed the guidelines and installed all the necessary nightly builds. After running ./scripts/e2e-tests.sh, the tests/erc721-consecutive.rs tests were failing with the following output:

     Running tests/erc721-consecutive.rs (target/debug/deps/erc721_consecutive-3d27de35530b233d)

running 6 tests
test error_when_exceed_batch_size ... FAILED
test error_when_to_is_zero ... FAILED
test constructs ... FAILED
test burns ... FAILED
test mints ... FAILED
test transfers_from ... FAILED

failures:

---- error_when_exceed_batch_size stdout ----
110877347320130
wasm data fee: Ξ0.000111
thread 'error_when_exceed_batch_size' panicked at /home/nenad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koba-0.2.0/src/assembler/labeler.rs:69:40:
Label 'data_c167b0e3c82238f4f2d1a50a8b3a44f96311d77b148c30dc0ef863e1a060dcb6' not found
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- error_when_to_is_zero stdout ----
110877347320130
wasm data fee: Ξ0.000111
thread 'error_when_to_is_zero' panicked at /home/nenad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koba-0.2.0/src/assembler/labeler.rs:69:40:
Label 'data_c167b0e3c82238f4f2d1a50a8b3a44f96311d77b148c30dc0ef863e1a060dcb6' not found

---- constructs stdout ----
110877347320130
wasm data fee: Ξ0.000111
thread 'constructs' panicked at /home/nenad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koba-0.2.0/src/assembler/labeler.rs:69:40:
Label 'data_c167b0e3c82238f4f2d1a50a8b3a44f96311d77b148c30dc0ef863e1a060dcb6' not found

---- burns stdout ----
110877347320130
wasm data fee: Ξ0.000111
thread 'burns' panicked at /home/nenad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koba-0.2.0/src/assembler/labeler.rs:69:40:
Label 'data_c167b0e3c82238f4f2d1a50a8b3a44f96311d77b148c30dc0ef863e1a060dcb6' not found

---- mints stdout ----
110877347320130
wasm data fee: Ξ0.000111
thread 'mints' panicked at /home/nenad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koba-0.2.0/src/assembler/labeler.rs:69:40:
Label 'data_c167b0e3c82238f4f2d1a50a8b3a44f96311d77b148c30dc0ef863e1a060dcb6' not found

---- transfers_from stdout ----
110877347320130
wasm data fee: Ξ0.000111
thread 'transfers_from' panicked at /home/nenad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koba-0.2.0/src/assembler/labeler.rs:69:40:
Label 'data_c167b0e3c82238f4f2d1a50a8b3a44f96311d77b148c30dc0ef863e1a060dcb6' not found


failures:
    burns
    constructs
    error_when_exceed_batch_size
    error_when_to_is_zero
    mints
    transfers_from

test result: FAILED. 0 passed; 6 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.09s

error: test failed, to rerun pass `-p erc721-consecutive-example --test erc721-consecutive`

platform

  • linux
  • windows
  • macos

Expected behavior

Tests in tests/erc721-consecutive.rs should have passed.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added needs triage Needs to be assigned the appropriate labels type: bug Something is not working as intended. labels Sep 16, 2024
@bidzyyys
Copy link
Collaborator

Hi @0xNeshi!
Thank you for submitting this issue.
Have you followed all the steps from this CI build?
https://github.com/OpenZeppelin/rust-contracts-stylus/actions/runs/10848468137/job/30105638596

@0xNeshi
Copy link
Collaborator Author

0xNeshi commented Sep 16, 2024

Running tests with exact specs from CI build ([email protected], [email protected]) results in passing tests! ✔️
I was originally running them with [email protected] and [email protected].

Should this still be considered a bug then or are tests expected to fail with newer pkg versions?

P.S. Documentation on running E2E tests is out of sync in any case, I can create a new issue to update it, does that sound good?

@qalisander
Copy link
Member

Now the documentation is updated. Currently we're temporarily tied to the older version of solidity. We will wait till Offchain Labs adds constructors to the stylus-sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Needs to be assigned the appropriate labels type: bug Something is not working as intended.
Projects
None yet
Development

No branches or pull requests

3 participants