Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: SafeERC20 utility #279

Open
1 task done
ggonzalez94 opened this issue Sep 11, 2024 · 3 comments · May be fixed by #289
Open
1 task done

[Feature]: SafeERC20 utility #279

ggonzalez94 opened this issue Sep 11, 2024 · 3 comments · May be fixed by #289
Assignees
Labels
effort: medium Default level of effort. good first issue Good for newcomers. type: feature New feature request.

Comments

@ggonzalez94
Copy link
Collaborator

What is the feature you would like to see?

Wrappers around ERC-20 operations that throw on failure.
Reference implementation: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/utils/SafeERC20.sol

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@ggonzalez94 ggonzalez94 added type: feature New feature request. needs triage Needs to be assigned the appropriate labels labels Sep 11, 2024
@ggonzalez94 ggonzalez94 added this to the Release v0.2.0 milestone Sep 11, 2024
@ggonzalez94 ggonzalez94 added good first issue Good for newcomers. effort: medium Default level of effort. and removed needs triage Needs to be assigned the appropriate labels labels Sep 11, 2024
@vking45
Copy link

vking45 commented Sep 11, 2024

I would like to take up this issue

@bidzyyys
Copy link
Collaborator

@vking45 thanks for wanting to contribute to the library 🚀 Of course you can work on this issue!
It would be great if you can submit a draft PR with your initial design/implementation, that way our team can give you feedback early on.

@0xNeshi 0xNeshi linked a pull request Sep 17, 2024 that will close this issue
2 tasks
@0xNeshi
Copy link

0xNeshi commented Sep 17, 2024

@bidzyyys created a draft PR with just safe_transfer implemented to show what is the idea for the utility's design, let me know if you have any feedback and if you think I can continue working on this.

Note that the documentation within the PR is copy/pasted from the Solidity version, it's low priority atm and is still wip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. good first issue Good for newcomers. type: feature New feature request.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants