Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor benchmarking infra #170

Open
Tracked by #106
alexfertel opened this issue Jul 1, 2024 · 0 comments
Open
Tracked by #106

Refactor benchmarking infra #170

alexfertel opened this issue Jul 1, 2024 · 0 comments
Labels
effort: medium Default level of effort. priority: 0 Nice-to-have. Willing to ship without this. type: ref A code update that doesn't meaningfully change functionality. uphill Some research/design is needed before this can be implemented.

Comments

@alexfertel
Copy link
Contributor

alexfertel commented Jul 1, 2024 •
edited
Loading

Currently, our benchmarking suite is quite rough and has a bunch of code dependent on e2e, we should decouple them.

Benches are also coupled to displaying the results, which should not be the case. Once this coupling is gone, it should make adding the results as a comment on a PR much easier, as mentioned in #169
@alexfertel alexfertel mentioned this issue Jul 1, 2024
Open
1 task
@alexfertel alexfertel changed the title Extract away benchmarking infra to a separate module Refactor benchmarking infra Jul 1, 2024
@alexfertel alexfertel added priority: 0 Nice-to-have. Willing to ship without this. effort: medium Default level of effort. uphill Some research/design is needed before this can be implemented. type: ref A code update that doesn't meaningfully change functionality. labels Jul 1, 2024
This was referenced Jul 15, 2024
Merged
Merged
alexfertel added a commit that referenced this issue Jul 18, 2024
@alexfertel
ref: rework gas usage reporting (#203)
a2cb3c6 
Partially completes #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 0 Nice-to-have. Willing to ship without this. type: ref A code update that doesn't meaningfully change functionality. uphill Some research/design is needed before this can be implemented.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexfertel