Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: implement shims for motsu #156

Open
1 of 3 tasks
bidzyyys opened this issue Jun 24, 2024 · 0 comments
Open
1 of 3 tasks

[Feature]: implement shims for motsu #156

bidzyyys opened this issue Jun 24, 2024 · 0 comments
Labels
effort: medium Default level of effort. priority: 1 We will do our best to deal with this. type: feature New feature request. type: test Changes to the testing suite.

Comments

@bidzyyys
Copy link
Collaborator

What is the feature you would like to see?

Some of the shims are "dummy" implemented (No-op) lib/motsu/src/shims.rs

We should provide the correct implementation for them:

  • return_data_size
  • read_return_data

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@bidzyyys bidzyyys added type: feature New feature request. needs triage Needs to be assigned the appropriate labels labels Jun 24, 2024
@bidzyyys bidzyyys mentioned this issue Jun 24, 2024
Merged
@alexfertel alexfertel added priority: 1 We will do our best to deal with this. type: test Changes to the testing suite. effort: medium Default level of effort. and removed needs triage Needs to be assigned the appropriate labels labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 1 We will do our best to deal with this. type: feature New feature request. type: test Changes to the testing suite.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexfertel @bidzyyys