Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improve binary size measurements #154

Open
1 task done
alexfertel opened this issue Jun 24, 2024 · 0 comments
Open
1 task done

[Feature]: Improve binary size measurements #154

alexfertel opened this issue Jun 24, 2024 · 0 comments
Labels
effort: medium Default level of effort. github_actions Pull requests that update GitHub Actions code type: feature New feature request. type: perf Performance work.

Comments

@alexfertel
Copy link
Contributor

alexfertel commented Jun 24, 2024

What is the feature you would like to see?

The check_wasm workflow outputs binary sizes for our example contracts, like this:

Screenshot 2024-06-24 at 11 04 38

It would be nice to:

  • Make this workflow faster by directly measuring binary size (compressed & uncompressed) instead of using cargo stylus.
  • Increase the precision of the measurement, i.e., display the full size in bytes instead of the approximation in KB.
  • Research if there's an easy way to display the impact in a PR comment a la codecov?

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@alexfertel alexfertel added type: feature New feature request. type: perf Performance work. effort: medium Default level of effort. github_actions Pull requests that update GitHub Actions code labels Jun 24, 2024
@alexfertel alexfertel changed the title [Feature]: Improve binary size measurement precision [Feature]: Improve binary size measurements Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. github_actions Pull requests that update GitHub Actions code type: feature New feature request. type: perf Performance work.
Projects
Status: Todo
Development

No branches or pull requests

1 participant