Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing framework #111

Open
bradleyjeck opened this issue Mar 1, 2017 · 2 comments
Open

testing framework #111

bradleyjeck opened this issue Mar 1, 2017 · 2 comments

Comments

@bradleyjeck
Copy link

it's great to see some unit tests coming into the project! As there are not too many tests yet, I was curious how much thought had been given to the test framework? Over on a branch of epanet-dev, I started adding a tests under the CMake framework https://github.com/bradleyjeck/epanet-dev/tree/structure-for-testing

An advantage of using CMake is that it does not introduce another dependency like Boost. Of course Boost and other frameworks have their own advantages. Just thought it might be worth opening the topic while making a change is easy.

@samhatchett
Copy link
Member

Hey @bradleyjeck - did you mean to post this on the EPANET project?

RTX uses BOOST already so I wouldn't view this as an extra dependency. That also answers the other question about how much thought went into it -- since BOOST is an existing requirement, and is header-only, I figured it would be easy to integrate.

@bradleyjeck
Copy link
Author

Hi @samhatchett - thanks for the feedback. Posting here was intentional as I was curious about the choice for this project. RTX has good reasons for Boost which is great. That may attract other related projects like EPANET in the same direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants