Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should a check valve be a valve or a pipe? #106

Open
jamesuber opened this issue Nov 30, 2016 · 0 comments
Open

should a check valve be a valve or a pipe? #106

jamesuber opened this issue Nov 30, 2016 · 0 comments
Labels

Comments

@jamesuber
Copy link
Member

Right now it seems to be considered to be a valve, different from a pipe. Result is that when you change a pipe to a check valve, then it gets confusing about whether that's really a different type of object, and existing data connections can be severed. For example a valve can accept a setting, but that doesn't apply logically to a check valve, so its more like a pipe in that case. however it's useful to keep track of check valves, different from pipes. So no change should be made to harm our ability to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant