Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWA-EPANET wrapper needs to be properly packaged #82

Open
samhatchett opened this issue Jul 6, 2021 · 6 comments
Open

OWA-EPANET wrapper needs to be properly packaged #82

samhatchett opened this issue Jul 6, 2021 · 6 comments

Comments

@samhatchett
Copy link
Member

PRs welcome!

@samhatchett
Copy link
Member Author

... see closed issues referenced above for examples of how the wrapper is not properly packaged :)

@michaeltryby
Copy link
Contributor

This set of issues I raised establish a baseline for the current state of the project. Each platform handles Python extension build, linking, and resolves shared library locations at runtime slightly differently.

@samhatchett
Copy link
Member Author

samhatchett commented Jul 7, 2021

I guess the question is whether a baseline is even necessary given that what exists now was created to serve immediate purposes, unrelated to wide adoption and scalability [edit: in terms of packaging/distribution]. The ultimate solution is not to document all the individual shortcomings of the current setup and address each one as a separate issue.

From your comments, it looks like there's lots of great stuff over on the swmm-python project that can be readily adapted here. You have suggested doing so, and received no pushback - only clarifying questions to try and comprehend the scope of changes.

@samhatchett
Copy link
Member Author

digging in a bit further... @michaeltryby it looks like you already have a (mostly?) functional wrapper set up at https://github.com/michaeltryby/epanet-python/tree/dev/epanet-toolkit

would you like to highlight the differences between what is in this repo and what you have been working on?

@michaeltryby
Copy link
Contributor

michaeltryby commented Jul 7, 2021

@samhatchett thats the staging area for the PR I’m assembling. Give me a call if you want to talk.

@samhatchett
Copy link
Member Author

that's great - looking forward to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants