Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction to do a recursive clone before attempting a build #66

Conversation

yaash45
Copy link
Contributor

@yaash45 yaash45 commented Sep 25, 2024

I made a quick PR to address this issue I created here #65.

Fixes #65

Copy link

linux-foundation-easycla bot commented Sep 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@yaash45 yaash45 force-pushed the readme-git-clone-recursive-instruction-improvement-65 branch from 346fe83 to 57f3bd6 Compare September 25, 2024 00:45
README.md Outdated Show resolved Hide resolved
@yaash45 yaash45 force-pushed the readme-git-clone-recursive-instruction-improvement-65 branch from 57f3bd6 to 3609c25 Compare September 25, 2024 00:52
@jminor
Copy link
Member

jminor commented Sep 26, 2024

I see there is also #55 which takes a slightly different approach to fix the same issue. @ddouglas and @yaash45 would you two like to discuss pros/cons of either or both of these?

@yaash45
Copy link
Contributor Author

yaash45 commented Sep 26, 2024

I see there is also #55 which takes a slightly different approach to fix the same issue. @ddouglas and @yaash45 would you two like to discuss pros/cons of either or both of these?

Sure thing! Thanks for linking the other PR. I like that #55 adds the submodule command into the build instructions. It would help to keep the submodules up-to-date. I think it needs some fixing though, the formatting is off. I can leave a comment on it.

@jminor
Copy link
Member

jminor commented Sep 27, 2024

If @ddouglas isn't available right now (that PR was from a month ago) then you can fold that change into yours @yaash45 and then we can add a "Co-authored-by:" to the squashed commit when we merge the PR, so you both get credit for the contribution.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@yaash45
Copy link
Contributor Author

yaash45 commented Sep 27, 2024

If @ddouglas isn't available right now (that PR was from a month ago) then you can fold that change into yours @yaash45 and then we can add a "Co-authored-by:" to the squashed commit when we merge the PR, so you both get credit for the contribution.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Sounds good, I can combine our changes. I can't seem to find @ddouglas 's email address to add to the commit. Please let me know if the user name will suffice in the commit message. Thanks!

README.md Show resolved Hide resolved
@jminor jminor merged commit ebbf128 into OpenTimelineIO:main Sep 28, 2024
6 checks passed
jspada200 pushed a commit to jspada200/raven that referenced this pull request Oct 1, 2024
…enTimelineIO#66)

* Merge in changes from OpenTimelineIO#55 + Improve build steps formatting

Co-authored-by: David Douglas @ddouglas
Signed-off-by: Yaash Jain <[email protected]>
Signed-off-by: jspadafora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention recursive clone / submodule init in build instructions
3 participants