-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instruction to do a recursive clone before attempting a build #66
Add instruction to do a recursive clone before attempting a build #66
Conversation
346fe83
to
57f3bd6
Compare
Signed-off-by: Yaash Jain <[email protected]>
Signed-off-by: Yaash Jain <[email protected]>
57f3bd6
to
3609c25
Compare
Sure thing! Thanks for linking the other PR. I like that #55 adds the submodule command into the build instructions. It would help to keep the submodules up-to-date. I think it needs some fixing though, the formatting is off. I can leave a comment on it. |
Sounds good, I can combine our changes. I can't seem to find @ddouglas 's email address to add to the commit. Please let me know if the user name will suffice in the commit message. Thanks! |
Co-authored-by: David Douglas @ddouglas Signed-off-by: Yaash Jain <[email protected]>
…struction-improvement-65
Signed-off-by: Yaash Jain <[email protected]>
…enTimelineIO#66) * Merge in changes from OpenTimelineIO#55 + Improve build steps formatting Co-authored-by: David Douglas @ddouglas Signed-off-by: Yaash Jain <[email protected]> Signed-off-by: jspadafora <[email protected]>
I made a quick PR to address this issue I created here #65.
Fixes #65