Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings need update to match latest OTIO #50

Open
meshula opened this issue Mar 2, 2023 · 1 comment
Open

Bindings need update to match latest OTIO #50

meshula opened this issue Mar 2, 2023 · 1 comment

Comments

@meshula
Copy link
Member

meshula commented Mar 2, 2023

/home/runner/work/OpenTimelineIO-C-Bindings/OpenTimelineIO-C-Bindings/src/copentimelineio/serializableObject.cpp: In function ‘bool SerializableObject_to_json_file(OTIOSerializableObject*, const char*, OTIOErrorStatus*, int)’:
[88](https://github.com/OpenTimelineIO/OpenTimelineIO-C-Bindings/actions/runs/4299901107/jobs/7495571690#step:5:89)
/home/runner/work/OpenTimelineIO-C-Bindings/OpenTimelineIO-C-Bindings/src/copentimelineio/serializableObject.cpp:57:13: error: invalid conversion from ‘int’ to ‘const schema_version_map*’ {aka ‘const std::unordered_map<std::__cxx11::basic_string<char>, long int>*’} [-fpermissive]
[89](https://github.com/OpenTimelineIO/OpenTimelineIO-C-Bindings/actions/runs/4299901107/jobs/7495571690#step:5:90)
   57 |             indent);
[90](https://github.com/OpenTimelineIO/OpenTimelineIO-C-Bindings/actions/runs/4299901107/jobs/7495571690#step:5:91)
      |             ^~~~~~
[91](https://github.com/OpenTimelineIO/OpenTimelineIO-C-Bindings/actions/runs/4299901107/jobs/7495571690#step:5:92)
      |             |
[92](https://github.com/OpenTimelineIO/OpenTimelineIO-C-Bindings/actions/runs/4299901107/jobs/7495571690#step:5:93)
      |             int
@rogergodspeed
Copy link
Contributor

@meshula Do you think this is still relevant since the merge of #58 ?

I know we hardcoded the empty map into the schema version calls, but I do think this means the overall binding is at least tracking with the proper version of the ASWF OTIO submodule repo and API version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants