Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Korean localization for new localization labels. #1164

Merged
merged 47 commits into from
Oct 9, 2024

Conversation

Tomuri32
Copy link
Contributor

I wanted the GP2040-CE Web Configurator in Korean

Copy link
Contributor Author

@Tomuri32 Tomuri32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change wiiaddon.jax file

@Pelsin
Copy link
Contributor

Pelsin commented Sep 30, 2024

Wow so nice to see korean being added <3!
If there are strings that don't need translating/should be kept with the original string, please remove them from the ko-kr locale and it will fallback to the english(default) one.

@Tomuri32
Copy link
Contributor Author

Wow so nice to see korean being added <3! If there are strings that don't need translating/should be kept with the original string, please remove them from the ko-kr locale and it will fallback to the english(default) one.

thanks! :)

@mizma
Copy link
Contributor

mizma commented Oct 1, 2024

Nice to see new locales being added!
https://github.com/OpenStickCommunity/GP2040-CE/pull/1048/files this commit log might help in figuring out how to get the new language appear in the final web config build.

  • www/src/Components/LanguageSelector.jsx
    • add the locale in language selector so the language can be changed.
    • add link to the country flag icon
  • need to add www/src/Icons/Flags/koKR.tsx
  • www/src/i18n.jsx
    • add the locale to i18next so the new language is loaded
  • www/src/Locales/**/Components.jsx
    • need to add the translation of the language name in language selector.

@Tomuri32
Copy link
Contributor Author

Tomuri32 commented Oct 1, 2024

Nice to see new locales being added! https://github.com/OpenStickCommunity/GP2040-CE/pull/1048/files this commit log might help in figuring out how to get the new language appear in the final web config build.

  • www/src/Components/LanguageSelector.jsx

    • add the locale in language selector so the language can be changed.
    • add link to the country flag icon
  • need to add www/src/Icons/Flags/koKR.tsx

  • www/src/i18n.jsx

    • add the locale to i18next so the new language is loaded
  • www/src/Locales/**/Components.jsx

    • need to add the translation of the language name in language selector.

I have completed everything you informed me about. Thank you!

@arntsonl
Copy link
Contributor

arntsonl commented Oct 1, 2024

This is super cool!! We're are going to hold off on merging this for 0.7.11 as we have so many changes going into 0.7.10. I'll be approving and merging this after we get 0.7.10 release. Thank you for the PR!

I've changed it to a more natural translation
I've changed it to a more natural translation
I've changed it to a more natural translation
I've changed it to a more natural translation
I've changed it to a more natural translation
@Tomuri32
Copy link
Contributor Author

Tomuri32 commented Oct 3, 2024

This is super cool!! We're are going to hold off on merging this for 0.7.11 as we have so many changes going into 0.7.10. I'll be approving and merging this after we get 0.7.10 release. Thank you for the PR!

update ko-KR/Addons/WiiAddon.js

@Tomuri32
Copy link
Contributor Author

Tomuri32 commented Oct 9, 2024

[/ko-KR/Navigation.jsx] Delete the duplicate key.
[/ko_KR/LayoutConfig.jsx]I have fixed the missing '.

@arntsonl
Copy link
Contributor

arntsonl commented Oct 9, 2024

Would you like a little bit of time to fix anything? Or is this ready to merge?

@arntsonl
Copy link
Contributor

arntsonl commented Oct 9, 2024

Looks great! Any changes to this you can do as an additional PR, thanks for the contributions!!

@arntsonl arntsonl merged commit 920a0d7 into OpenStickCommunity:main Oct 9, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants