Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-ons with Input Modifiers fire AFTER the boot selection (fix this) #283

Closed
4 tasks done
arntsonl opened this issue May 25, 2023 · 0 comments · Fixed by #446
Closed
4 tasks done

Add-ons with Input Modifiers fire AFTER the boot selection (fix this) #283

arntsonl opened this issue May 25, 2023 · 0 comments · Fixed by #446

Comments

@arntsonl
Copy link
Contributor

Prerequisites

Please check the following before posting an issue / bug report.

  • I am running the latest version of the firmware found HERE
  • I have checked the documentation HERE and found no answer
  • I checked to make sure that this issue has not already been filed HERE
  • I am reporting the issue to the correct repository

Context

Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Firmware Version: 0.7.1
  • Name of device: All Devices
  • Link to where you purchased the device: *
  • Is this a custom build?: *
  • Operating System: *
  • Browser: *

Expected Behavior

The Add-On system is currently not setup to handle input modifiers that fire before the boot selection process. This means that add-ons such as the Wii Extension and SNES/NES pad cannot trigger our web config or other hot keys during boot. We will want to move the logic so that add-ons can load AND run their first pre/post process before the boot actions are validated.

Current Behavior

Add-ons cannot modify the boot state and therefore cannot handle situations like the SNES 2 USB adapter. In this case, the SNES pad cannot put the GP2040-CE firmware into web config mode.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Enable SNES Mode add-on
  2. Using a device such as the SNES 2 USB or KB2040, hold the S2 or any other hotkey button on start-up
  3. Observe the GP2040-CE device does not go into web config or any other mode using an add-on device

Screenshots & Files

None for now
NickGuyver added a commit to NickGuyver/GP2040-CE that referenced this issue Aug 7, 2023
@NickGuyver
move add-ons before bootsel mode
a5d79a6 
Move the add-ons to load and read before the bootsel mode detection.

Fix issue with SNESpad not reading within start(), which caused held down buttons to always read 0 until repressed.

OpenStickCommunity#283
@NickGuyver NickGuyver mentioned this issue Aug 7, 2023
Merged
@NickGuyver NickGuyver linked a pull request Aug 17, 2023 that will close this issue
move add-ons before bootsel mode #446
Merged
arntsonl added a commit that referenced this issue Aug 17, 2023
@NickGuyver @arntsonl
move add-ons before bootsel mode (#446)
8e81a22 
* move add-ons before bootsel mode

Move the add-ons to load and read before the bootsel mode detection.

Fix issue with SNESpad not reading within start(), which caused held down buttons to always read 0 until repressed.

#283

* restore snespad.c

* snes_input.c fix for boot selection

* tabs

* add wiiext.cpp changes

* Update gp2040.cpp

These both need to be LoadUSBAddon() calls

---------

Co-authored-by: Luke Arntson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move add-ons before bootsel mode NickGuyver/GP2040-CE
1 participant
@arntsonl