Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade wicked_pdf to 2.6.3 #477

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented Jan 26, 2024

🎩 Description

Please describe your pull request.

Downgrade wicked_pdf to be compatible with Webpacker.
Add specs

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

If you have a Running Docker env you can easily setup using : make run

Tasks

  • Add specs
  • Downgrade wicked_pdf

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4ae434) 89.34% compared to head (d64a913) 89.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #477   +/-   ##
========================================
  Coverage    89.34%   89.34%           
========================================
  Files           65       65           
  Lines         1595     1595           
========================================
  Hits          1425     1425           
  Misses         170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review January 26, 2024 10:56
@Quentinchampenois Quentinchampenois requested review from luciegrau and a team January 26, 2024 10:56
@Quentinchampenois Quentinchampenois merged commit a703fef into develop Jan 31, 2024
16 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/export_pdf_signature branch January 31, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants