Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate settings for dev, predev and production. #200

Merged

Conversation

amakarudze
Copy link
Contributor

Checklist

  • [No ] My branch is up-to-date with the upstream develop branch.
  • [Yes ] I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #

Brief description of what this PR does.
#164. Separate settings for dev, predev and production. Also removes 'SECRET_KEY' value from the settings file.

Why do we need this PR?:
To address issue #164.
If relevant, please include a screenshot.

Demo (optional):

Some tips for you to write the instructions:

  • Create an environment variable 'SECRET_KEY' on your PC (follow instructions for your OS). This should be assigned the secret key contained in travis.yml.

Testing instructions:

  • Run python manage.py runserver. If your environment variable is set correctly, website will launch properly. If not, you will get 'ImproperlyConfigured("The SECRET_KEY setting must not be empty.")' error message.

If there is any work still left to do, please add it here.

TODOs (if any):

A picture of a cute animal (not mandatory but encouraged):
rabbit-2415967_960_720

from .base import *


DEBUG = os.getenv("DEBUG", False)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'os' may be undefined, or defined from star imports: .base

@@ -0,0 +1,5 @@
# production settings
from .base import *

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'from .base import *' used; unable to detect undefined names

from .base import *


DEBUG = os.getenv("DEBUG", True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'os' may be undefined, or defined from star imports: .base

@@ -0,0 +1,5 @@
# predev settings
from .base import *

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'from .base import *' used; unable to detect undefined names

from .base import *


DEBUG = os.getenv("DEBUG", False)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'os' may be undefined, or defined from star imports: .base

@@ -0,0 +1,5 @@
# dev settings
from .base import *

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'from .base import *' used; unable to detect undefined names

@@ -16,6 +16,7 @@ install:
- pip install coveralls

before_script:
- export SECRET_KEY='x1-pogt0-b5owbgq0=ui02-4v)bba!bg&1m8_$)8-&13(907qf'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this by enabling Travis for your fork?

Copy link
Member

@tapaswenipathak tapaswenipathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one again! 🎉

It is super easy to remove hound errors appearing in your pr, just follow what the fix is saying, linking a useful read.

@tapaswenipathak tapaswenipathak merged commit d918ef1 into OpenSourceHelpCommunity:predev Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants