Use URL encoding for binary values #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saper
commented
Sep 28, 2024
| )) != CKR_OK | ||
| ) { | ||
| goto cleanup; | ||
| } |
There was a problem hiding this comment.
If we don't check the error code here, an unmodified "empty" target buffer will be returned in case _pkcs11h_util_binaryToHex fails. This could go into master anyway.
saper
force-pushed
the
pkcs11-uri-submit-01
branch
from
7e94936
to
4fe8d58
Compare
|
This is changing the legacy, serialisation format? Is there any need to do that? We should be using RFC7512 URIs by default and only accepting the legacy format for compatibility, surely? Changing the legacy format doesn't seem like it's going to help anything? |
|
This is PR is the first step towards PKCS#11 URLs. It shouldn't be merged at this stage. I just try to see how much we can re-use the existing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PKCS#11 URI format is desired, as proposed #4, let's tell our binary serialization routines to accept and generate
%20instead of\x20.