Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mstestv3 as testing framework #372

Merged
merged 19 commits into from
Nov 2, 2023

Conversation

Daniel-Svensson
Copy link
Member

@Daniel-Svensson Daniel-Svensson commented Aug 26, 2022

Note: mstest v2 have some serious problems when multiple projects use DeploymentItem so it will always fail if running booth "Tools" tests from within VS.

This pr is quite old,. the support is now better so want to se how it works in devops.

Maybe mstestv2 can be used for all projects except tools tests ??

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 26, 2022

This pull request introduces 1 alert when merging cc89db9 into 31a186b - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@Daniel-Svensson Daniel-Svensson changed the title Use mstestv2 as testing framework Use mstestv3 as testing framework Jun 9, 2023
@Daniel-Svensson Daniel-Svensson marked this pull request as ready for review October 31, 2023 09:15
@Daniel-Svensson Daniel-Svensson enabled auto-merge (squash) October 31, 2023 12:41
@@ -79,7 +58,7 @@
// do verification ...
if (XmlReader == null)
{
XmlReader = XmlReader.Create(this.TestContext.TestDeploymentDir + "\\NotificationMethodGeneratorTestCodeSnippets.xml");
XmlReader = XmlReader.Create("NotificationMethodGeneratorTestCodeSnippets.xml");

Check notice

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Daniel-Svensson Daniel-Svensson merged commit 63883b0 into OpenRIAServices:main Nov 2, 2023
6 checks passed
@Daniel-Svensson Daniel-Svensson deleted the feature/mstest2 branch November 2, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant