Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-query attention for encoder-decoder models #1339

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Support multi-query attention for encoder-decoder models #1339

merged 2 commits into from
Jul 12, 2023

Conversation

guillaumekln
Copy link
Collaborator

Closes #1328.

@vince62s
Copy link
Member

you don't want to handle shared layer norm / parallel residual in the same PR ?

@guillaumekln
Copy link
Collaborator Author

No, that can be done in a separate PR.

@guillaumekln guillaumekln merged commit dac2f62 into OpenNMT:master Jul 12, 2023
17 checks passed
@guillaumekln guillaumekln deleted the enc-dec-multi-query branch July 12, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error inference seq2seq transformer model with multiquery: true
2 participants
@guillaumekln @vince62s